Files
cedricandClaude Opus 5.5 ca53cedc32 Aperçu : détection automatique des fichiers texte et réglages
- Hors liste blanche, reniflage du contenu (UTF-8 valide, sans NUL, peu de caractères de contrôle) : .pem, .csr, fichiers sans extension... servis en text/plain avec les mêmes protections
- Langage deviné côté client (highlight.js), sauf blocs PEM/PGP
- Paramètres > Aperçu : préférences d'affichage par navigateur (coloration, numéros de ligne, retour à la ligne, Markdown rendu/source, CSV) ; réglages administrateur (détection, plafond 1-50 Mo, extensions texte, extensions exclues, aperçu dans les partages)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 12:19:30 +01:00

222 lines
9.3 KiB
Go

package api
import (
"strings"
"testing"
"github.com/vblogio/upandown/internal/storage"
)
func TestPreviewKind(t *testing.T) {
for name, k := range map[string]string{
"a.txt": PreviewText, "x/app.LOG": PreviewText, "d.csv": PreviewCSV, "README.md": PreviewMarkdown,
"doc.pdf": PreviewPDF, "c.json": PreviewCode, "i.html": PreviewCode, "k.yaml": PreviewCode,
"Dockerfile": PreviewCode, "dockerfile.dev": PreviewCode, "Makefile": PreviewCode,
"a.docx": "", "a.rtf": "", "a.doc": "", "a.png": "", "a.exe": "", "noext": "",
} {
if got := PreviewKind(name); got != k {
t.Errorf("PreviewKind(%q) = %q, attendu %q", name, got, k)
}
}
}
func TestPreviewHeadersAndWhitelist(t *testing.T) {
f := newFixture(t, nil)
s := f.register("alice")
want(t, s.put("page.html", "<script>alert(1)</script>"), 200)
want(t, s.put("data.csv", "a,b\n1,2\n"), 200)
want(t, s.put("note.md", "# titre"), 200)
want(t, s.put("doc.pdf", "%PDF-1.4\n"), 200)
want(t, s.put("x.docx", "PK"), 200)
want(t, s.put("bin.log", "abc\x00def"), 200)
// Même authentification que le téléchargement.
want(t, f.session().get("/api/preview?path=page.html"), 401)
for p, ct := range map[string]string{
"page.html": "text/plain; charset=utf-8",
"data.csv": "text/csv; charset=utf-8",
"note.md": "text/markdown; charset=utf-8",
"doc.pdf": "application/pdf",
} {
w := s.get("/api/preview?path=" + p)
want(t, w, 200)
h := w.Header()
if h.Get("Content-Type") != ct {
t.Errorf("%s : Content-Type %q, attendu %q", p, h.Get("Content-Type"), ct)
}
if !strings.HasPrefix(h.Get("Content-Disposition"), "inline;") || h.Get("X-Content-Type-Options") != "nosniff" {
t.Errorf("%s : en-têtes %v", p, h)
}
csp := h.Get("Content-Security-Policy")
if !strings.Contains(csp, "default-src 'none'") {
t.Errorf("%s : CSP %q", p, csp)
}
if p != "doc.pdf" && !strings.HasPrefix(csp, "sandbox") {
t.Errorf("%s : CSP sans sandbox %q", p, csp)
}
}
if b := s.get("/api/preview?path=page.html").Body.String(); b != "<script>alert(1)</script>" {
t.Errorf("contenu HTML : %q", b)
}
want(t, s.get("/api/preview?path=x.docx"), 415)
want(t, s.get("/api/preview?path=bin.log"), 415)
want(t, s.get("/api/preview?path=absent.txt"), 404)
want(t, s.get("/api/preview?path=../../etc/passwd.txt"), 404) // normalisé sous la racine
want(t, s.get("/api/preview?path=.accounts.json"), 400)
}
func TestPreviewTextCap(t *testing.T) {
f := newFixture(t, nil)
f.handler.PreviewMaxText = 10
s := f.register("alice")
want(t, s.put("court.txt", "court"), 200)
want(t, s.put("long.txt", "abcdefghié12345"), 200) // é sur les octets 10-11 : coupé à 9
w := s.get("/api/preview?path=court.txt")
want(t, w, 200)
if w.Body.String() != "court" || w.Header().Get("X-Preview-Truncated") != "0" || w.Header().Get("X-Preview-Size") != "5" {
t.Errorf("court : %q %v", w.Body, w.Header())
}
w = s.get("/api/preview?path=long.txt", "Range", "bytes=0-2")
want(t, w, 200) // pas de Range sur l'extrait
if w.Body.String() != "abcdefghi" || w.Header().Get("X-Preview-Truncated") != "1" || w.Header().Get("X-Preview-Size") != "16" {
t.Errorf("long : %q %v", w.Body, w.Header())
}
}
func TestPublicPreview(t *testing.T) {
f := newFixture(t, nil)
s := f.register("alice")
want(t, s.put("dir/a.go", "package a"), 200)
want(t, s.put("dir/b.zip", "PK\x03\x04\x00\x00"), 200)
sh := decode[storage.Share](t, s.json("POST", "/api/shares", map[string]any{"path": "dir", "days": 1}))
v := f.session()
w := v.get("/api/public/" + sh.Token + "/preview?sub=a.go")
want(t, w, 200)
if w.Body.String() != "package a" || w.Header().Get("X-Preview-Kind") != PreviewCode {
t.Errorf("public : %q %v", w.Body, w.Header())
}
want(t, v.get("/api/public/"+sh.Token+"/preview?sub=b.zip"), 415)
want(t, v.get("/api/public/nope/preview?sub=a.go"), 404)
}
func TestPreviewSniffUnknownExtensions(t *testing.T) {
f := newFixture(t, nil)
s := f.register("alice")
pem := "-----BEGIN CERTIFICATE-----\nMIIBszCCAVmgAwIBAgIUQ==\n-----END CERTIFICATE-----\n"
want(t, s.put("certs/server.pem", pem), 200)
want(t, s.put("certs/hosts", "127.0.0.1 localhost\n"), 200)
want(t, s.put("certs/vide.cfgx", ""), 200)
want(t, s.put("bin/blob.bin", "\x7fELF\x02\x01\x01\x00\x00"), 200)
want(t, s.put("bin/latin1.dat", "caf\xe9 cr\xe8me"), 200)
want(t, s.put("bin/ctrl.dat", strings.Repeat("ab\x01\x02", 50)), 200)
want(t, s.put("doc/lettre.rtf", `{\rtf1\ansi Bonjour}`), 200)
for p, body := range map[string]string{"certs/server.pem": pem, "certs/hosts": "127.0.0.1 localhost\n", "certs/vide.cfgx": ""} {
w := s.get("/api/preview?path=" + p)
want(t, w, 200)
h := w.Header()
if w.Body.String() != body || h.Get("Content-Type") != "text/plain; charset=utf-8" || h.Get("X-Preview-Kind") != PreviewText ||
h.Get("X-Preview-Detected") != "1" || !strings.HasPrefix(h.Get("Content-Security-Policy"), "sandbox") || h.Get("X-Content-Type-Options") != "nosniff" {
t.Errorf("%s : %q %v", p, w.Body, h)
}
}
// Liste blanche : pas de reniflage.
if w := s.get("/api/preview?path=certs/../certs/server.pem"); w.Header().Get("X-Preview-Detected") != "1" {
t.Errorf("chemin normalisé : %v", w.Header())
}
want(t, s.put("a.json", "{}"), 200)
if w := s.get("/api/preview?path=a.json"); w.Header().Get("X-Preview-Detected") != "0" {
t.Errorf("liste blanche : %v", w.Header())
}
for _, p := range []string{"bin/blob.bin", "bin/latin1.dat", "bin/ctrl.dat", "doc/lettre.rtf"} {
want(t, s.get("/api/preview?path="+p), 415)
}
// Reniflage aussi via un lien de partage.
sh := decode[storage.Share](t, s.json("POST", "/api/shares", map[string]any{"path": "certs", "days": 1}))
w := f.session().get("/api/public/" + sh.Token + "/preview?sub=server.pem")
want(t, w, 200)
if w.Body.String() != pem {
t.Errorf("public : %q", w.Body)
}
}
func TestSniffText(t *testing.T) {
long := strings.Repeat("é", 4096) // 8192 octets
for name, c := range map[string]struct {
b string
partial bool
ok bool
}{
"ascii": {"hello\n", false, true},
"utf8": {"café ☕", false, true},
"coupé toléré": {long[:8191], true, true},
"coupé final": {long[:8191], false, false},
"nul": {"a\x00b", false, false},
"esc couleurs": {"\x1b[31mrouge\x1b[0m\n", false, true},
"trop de ctrl": {"\x01\x02\x03abc", false, false},
"vide": {"", false, true},
} {
if got := sniffText([]byte(c.b), c.partial); got != c.ok {
t.Errorf("%s : %v, attendu %v", name, got, c.ok)
}
}
}
func TestPreviewSettings(t *testing.T) {
f := newFixture(t, nil)
admin := f.register("alice")
want(t, admin.put("k/server.pem", "-----BEGIN CERTIFICATE-----\n"), 200)
want(t, admin.put("k/notes.mylog", "ligne\n"), 200)
want(t, admin.put("k/app.log", "log\n"), 200)
want(t, admin.put("k/gros.txt", strings.Repeat("a", 3<<20)), 200)
st := decode[storage.Settings](t, admin.get("/api/settings"))
if p := st.Preview; !p.Sniff || p.MaxTextMB != 2 || !p.Shares || len(p.TextExts) != 0 || len(p.ExcludedExts) != 0 {
t.Fatalf("défauts : %+v", p)
}
if w := admin.get("/api/preview?path=k/gros.txt"); w.Body.Len() != 2<<20 || w.Header().Get("X-Preview-Truncated") != "1" {
t.Errorf("plafond 2 Mo : %d", w.Body.Len())
}
// Validation.
want(t, admin.json("PUT", "/api/settings", map[string]any{"preview": map[string]any{"maxTextMB": 0}}), 400)
want(t, admin.json("PUT", "/api/settings", map[string]any{"preview": map[string]any{"maxTextMB": 51}}), 400)
want(t, admin.json("PUT", "/api/settings", map[string]any{"preview": map[string]any{"textExts": []string{"a/b"}}}), 400)
st = decode[storage.Settings](t, admin.json("PUT", "/api/settings", map[string]any{"preview": map[string]any{
"sniff": false, "maxTextMB": 3, "textExts": []string{".MyLog", "mylog", " pem "}, "excludedExts": []string{"log"}, "shares": false,
}}))
if p := st.Preview; p.Sniff || p.MaxTextMB != 3 || p.Shares || strings.Join(p.TextExts, ",") != "mylog,pem" || strings.Join(p.ExcludedExts, ",") != "log" {
t.Fatalf("réglages : %+v", p)
}
// Un patch partiel ne touche pas aux autres champs.
st = decode[storage.Settings](t, admin.json("PUT", "/api/settings", map[string]any{"preview": map[string]any{"maxTextMB": 4}}))
if p := st.Preview; p.MaxTextMB != 4 || p.Sniff || strings.Join(p.TextExts, ",") != "mylog,pem" {
t.Fatalf("patch partiel : %+v", p)
}
w := admin.get("/api/preview?path=k/notes.mylog") // extension texte de l'administrateur
want(t, w, 200)
if w.Header().Get("X-Preview-Detected") != "0" || w.Header().Get("X-Preview-Kind") != PreviewText {
t.Errorf("textExts : %v", w.Header())
}
want(t, admin.get("/api/preview?path=k/app.log"), 415) // exclue
if w := admin.get("/api/preview?path=k/gros.txt"); w.Body.Len() != 3<<20 || w.Header().Get("X-Preview-Truncated") != "0" {
t.Errorf("plafond 4 Mo : %d", w.Body.Len())
}
// Reniflage désactivé : extension inconnue refusée.
want(t, admin.put("k/hosts", "127.0.0.1 localhost\n"), 200)
want(t, admin.get("/api/preview?path=k/hosts"), 415)
// Aperçu désactivé dans les partages.
sh := decode[storage.Share](t, admin.json("POST", "/api/shares", map[string]any{"path": "k", "days": 1}))
want(t, f.session().get("/api/public/"+sh.Token+"/preview?sub=server.pem"), 403)
// Réservé aux administrateurs.
want(t, admin.json("PUT", "/api/settings", map[string]any{"registration": "open"}), 200)
bob := f.register("bob")
want(t, bob.json("PUT", "/api/settings", map[string]any{"preview": map[string]any{"sniff": true}}), 403)
}