WIP: Paramètres : boutons Valider et Annuler #24

2026-10-05T11:03:12+02:00

claude Bot commented

2026-10-05 11:03:12 +02:00

Requested by Cédric

Before: every change in the Settings window was saved immediately (localStorage for Localization/Appearance, a server call per click for sources and tags).

After: changes show at once but are only kept with a Valider button placed in the left column under the tab labels. It turns to the accent color (with "Modifications non validées") while changes wait. Annuler goes back to the saved settings; closing the window (✕, Escape, backdrop) with unsaved changes asks for confirmation and drops them; leaving the page warns too. Purge, column-width reset and the Docker "show stopped" view toggle still act at once.

How: the UI keeps unsaved source changes in settings.pending (merged over the 4 s refresh so edits are not overwritten) and compares browser prefs and tags with a baseline taken when the window opens. Tags are now sent as one list with a new PUT /api/tags (atomic; known ids keep their code, new ones get id and code; on an invalid tag nothing is saved and index points to the row, whose error is shown). "Restaurer les tags par défaut" previews GET /api/tags/defaults until Valider. READMEs (EN/FR) updated.

Checks: go vet, go build, go test -race pass (new TestTagReplace). UI exercised in a static preview with a stubbed API: save/cancel/close for language, theme, tags (incl. invalid tag), syslog, audit, log files, Docker.

🤖 Generated with Claude Code

_Requested by **Cédric**_ Before: every change in the Settings window was saved immediately (localStorage for Localization/Appearance, a server call per click for sources and tags). After: changes show at once but are only kept with a **Valider** button placed in the left column under the tab labels. It turns to the accent color (with "Modifications non validées") while changes wait. **Annuler** goes back to the saved settings; closing the window (✕, Escape, backdrop) with unsaved changes asks for confirmation and drops them; leaving the page warns too. Purge, column-width reset and the Docker "show stopped" view toggle still act at once. How: the UI keeps unsaved source changes in `settings.pending` (merged over the 4 s refresh so edits are not overwritten) and compares browser prefs and tags with a baseline taken when the window opens. Tags are now sent as one list with a new `PUT /api/tags` (atomic; known ids keep their code, new ones get id and code; on an invalid tag nothing is saved and `index` points to the row, whose error is shown). "Restaurer les tags par défaut" previews `GET /api/tags/defaults` until Valider. READMEs (EN/FR) updated. Checks: `go vet`, `go build`, `go test -race` pass (new `TestTagReplace`). UI exercised in a static preview with a stubbed API: save/cancel/close for language, theme, tags (incl. invalid tag), syslog, audit, log files, Docker. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude Bot added 1 commit 2026-10-05 11:03:12 +02:00

Settings: Save and Cancel buttons instead of saving each change 194edee6de

Changes made in the Settings window show at once but are only kept with
the Save button, placed under the tab labels; it takes the accent color
while changes are waiting. Cancel goes back to the saved settings, and
closing the window (or the page) with unsaved changes asks first.

Tags are now sent as a whole list (PUT /api/tags, nothing saved when one
is invalid, the error gives its position) and "Restore default tags"
shows GET /api/tags/defaults until Save.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

cedric closed this pull request

2026-10-05 12:21:25 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

This pull request is marked as a work in progress.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vLab-BZH/logstream#24